Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP Two-factor authentication support #16

Closed
wants to merge 2 commits into from
Closed

TOTP Two-factor authentication support #16

wants to merge 2 commits into from

Conversation

tmagicturtle
Copy link

I am not sure if I should do the PR for the client patch since the dev loginserver is staff only at the moment. But here is that repo/branch: https://github.com/tmagicturtle/Pokemon-Showdown-Client/tree/patch-7

Requires 1 dependency: "2fa-util". It has two deps of its own, otplib and qrcode, and is a single MIT licensed file, so we can use it directly instead of requiring as a node package. But it carries much of the work - it securely generates TOTP secrets, handles verifying TOTP tokens, and generates QR codes for the end-user to scan in their 2FA app.

Functioning demonstration video: https://www.youtube.com/watch?v=znuIBtmO-R8

Adds asynchronous functions "request2fa" and "confirm2fa". Passes MFA token to login function.
@AnnikaCodes
Copy link
Contributor

I spoke to Zarel about this and we agreed that email-based password resets (#2) should be implemented before this, so users have a way to reset their accounts if they lose their TOTP source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants