Add test and fix gen 7 onSwitchInPriority

[andrebastosdias]

I had this PR directly on the branch before the SwitchIn overhaul merge.

I'm not sure if all the changes are correct, particularly whether the Move: 2 is necessary. I changed the method calls to singleEvent simply because that's how it is done across all the other effects.

Healing Wish and Lunar Dance need their onSwitchInPriority updated in the Gen 7 mod to match Gen 9.

I also added a test for the Throat Spray/Magician race condition reported here.

[pyuk-bot]

I used .call because that’s easier on the call stack, and because we have a built-in automatic crash when eventDepth gets too high. I guess it’s okay for onSwitchIn handlers to be using singleEvent because 'SwitchIn' is always eventDepth 1 the way we handle switches currently. As an example of what I’m worried about, Cloud Nine could set off an event chain like SwitchIn event -> cloudnine.onSwitchIn -> WeatherChange event -> protosynthesis.onWeatherChange -> Use event -> boosterenergy.onUse -> Start event -> protosynthesis.condition.onStart. Adding an extra singleEvent in there brings us up to eventDepth 5 which is uncomfortably close to the limit of 8. It would be nice if we didn’t need to do either, though, and could just define the alias directly in the data files, but JavaScript object literals apparently don’t support that in any way that isn’t weird and messy.

[andrebastosdias]

@pyuk-bot For the sake of consistency, we could use .call when it is used to avoid code repetition. Another example would be Flower Gift's Start event calling WeatherChange. I can code that tomorrow, I'm a bit busy right now.

[pyuk-bot]

I originally had all the onStart handlers that call onWeatherChange use .call too. Looking back at #9118, I apparently swapped to singleEvent at @urkerab's suggestion without any discussion on why one would be better than the other.

[andrebastosdias]

@pyuk-bot For the sake of consistency, we could use .call when it is used to avoid code repetition. Another example would be Flower Gift's Start event calling WeatherChange. I can code that tomorrow, I'm a bit busy right now.

I might do that in a separate PR.