Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and unskip tests #10887

Closed
wants to merge 10 commits into from
Closed

Conversation

andrebastosdias
Copy link
Contributor

@andrebastosdias andrebastosdias commented Feb 12, 2025

Unskips resolved tests and fixes:

  • Tera Shell + future attacks
  • White Herb (re-implemented similarly to Mirror Herb)
  • Order Up + Sheer Force

@andrebastosdias andrebastosdias changed the title Remove wrong test Unskip tests Feb 12, 2025
@andrebastosdias andrebastosdias changed the title Unskip tests Fix and unskip tests Feb 12, 2025
@pyuk-bot
Copy link
Contributor

https://www.youtube.com/watch?v=LZzvoM5QQIM&t=12067s This was the behavior for Ogerpon in dlc 1. I'm not sure why that test only exists in terapagos.js, but for accuracy's sake you could move it to ogerpon.js and run the test in the gen9dlc1 mod.

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Feb 12, 2025

That is not the test. That is an Ogerpon transformed into something else (which is still correct), not something transformed into Ogerpon.

@pyuk-bot
Copy link
Contributor

I would also suggest changing the test in terapagos.js to test for the correct behavior that we currently simulate rather than removing the test entirely.

@pyuk-bot
Copy link
Contributor

Sorry, I copied the wrong timecode. This is the one I meant: https://www.youtube.com/watch?v=LZzvoM5QQIM&t=8069s

@pyuk-bot
Copy link
Contributor

Won't that break White Herb being obtained by a Pokemon with lowered stats?

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Feb 12, 2025

I'll add a Start event to White Herb.

I can't create a gen9dlc1 battle.
Error: Unidentified format: gen9dlc1

@pyuk-bot
Copy link
Contributor

I can't create a gen9dlc1 battle. Error: Unidentified format: gen9dlc1

common.mod('gen9dlc1').createBattle(

@andrebastosdias
Copy link
Contributor Author

andrebastosdias commented Feb 12, 2025

common.mod('gen9dlc1').createBattle(

Error: Unidentified format: [gen9dlc1] Custom Game@@@!Team Preview,!Cancel Mod

It does not work

@andrebastosdias
Copy link
Contributor Author

I'll separate into multiple PR's

@andrebastosdias
Copy link
Contributor Author

It isn't possible to create a battle for a mod without a format. I move those tests to this PR #10814

@andrebastosdias andrebastosdias deleted the patch-1 branch February 13, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants