/ds: Add comparing stats

[WifiLatency]

Implements the suggestion Allow Dexsearch to compare stats

Lets users compare one stat category to another of the same pokemon using >, >=, <, <=, and =. For instance, /ds fairy, atk > spatk would return all fairy types with a greater attack than special attack.

[pyuk-bot]

I was going to suggest having a check for something like /ds atk > spa, spa > atk, but we currently allow /ds atk > 100, atk < 100 (which returns no results instead of an error) and /ds 90 > atk > 100 (which simply returns all Pokémon with less than 90 base Attack). I don’t understand how to trigger the “invalid stat range” message that’s already there.

[WifiLatency]

I was going to suggest having a check for something like /ds atk > spa, spa > atk, but we currently allow /ds atk > 100, atk < 100 (which returns no results instead of an error) and /ds 90 > atk > 100 (which simply returns all Pokémon with less than 90 base Attack). I don’t understand how to trigger the “invalid stat range” message that’s already there.

Looks like this gets triggered when you make an OR query which uses the same stat and direction. so /ds atk > 90 | atk > 100 triggers it. This is problematic behaviour since /ds atk > spatk | spe > spatk is a valid query. So I will need to fix that since I overlooked it. Thanks for pointing it out.

[pyuk-bot]

/ds atk > 90 | atk > 100 is a more valid range than /ds atk > 90, atk > 100 which is an allowed query. You could probably just drop that check entirely.

[WifiLatency]

/ds atk > 90 | atk > 100 is a more valid range than /ds atk > 90, atk > 100 which is an allowed query. You could probably just drop that check entirely.

Dropping the check as it is would result in the earlier values in the orgroup getting overwritten which would be misleading to users. To keep that behaviour from occuring the check will need to be rewritten to allow one each of hp/atk/def/spatk/spdef/spe/numeric for each stat and direction. /ds atk > spatk | atk > spe | atk > 100 would be valid but /ds atk > spatk | atk > spatk or /ds atk > 100 | atk > 90 should get errored due to having duplicate direction and stat types. Admittedly all this does is prevent duplicates when you're comparing one stat against another, but its still important for clarity with the numeric values.

The invalid ranges you're describing when ANDing together stat searches would probably get implemented in validParameter as this is what non flag searches like abilities or moves use. I could look at adding support for that after fixing the other error case.