Freebsd kqueue waitable child#91
Open
rogercoll wants to merge 6 commits intosmol-rs:masterfrom
Open
Conversation
notgull
requested changes
Nov 27, 2024
Comment on lines
+237
to
+246
| let exit_filter = unsafe { Filter::new(Exit::from_pid(NonZeroI32::new_unchecked( | ||
| child | ||
| .id() | ||
| .try_into() | ||
| .expect("could not transform pid to i32 type") | ||
| )))? | ||
| }; |
Contributor
There was a problem hiding this comment.
Can you reformat this to match rusfmt formatting? Unfortunately rustfmt doesn't auto-format code in macro blocks.
Contributor
|
@rogercoll I'm back, can you rebase on |
rogercoll
force-pushed
the
freebsd_kqueue_waitable_child
branch
from
5e7c2b5 to
a803019
Compare
Author
Done, not sure if the failure of macos CI is related to this PR 🤔 Thanks! |
Contributor
|
It's a bug in |
notgull
reviewed
Aug 7, 2025
Contributor
notgull
left a comment
notgull
left a comment
There was a problem hiding this comment.
This can be done for all of the following platforms, right?
#[cfg(any(
target_vendor = "apple",
target_os = "freebsd",
target_os = "netbsd",
target_os = "openbsd",
target_os = "dragonfly",
))]
Author
That's right, added support in e2583f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the WaitableChild struct for
freebsdsystems. In addition, the Wait approach will be used by default for freebsd systems.The PR explicitly implements the WaitableChild only for
freebsd, that is because of the lack of testing in other BSD systems. I would expect other systems supporting thekqueueevent notification interface to work as well (NetBSD, OpenBSD, DragonFly BSD, and macOS). Would it make sense to extend the implementation to cover these OSes too?Usage of smol-rs/async-io#207
Tests: all tests run with the WaitableChild instance.