metrics-server: try replacing helm with kustomize #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the use of the kustomize included in
kubectlinstead ofthe third-party
helmto deploy metrics-server.The way this works is roughly:
kubernetes-incubator/metrics-serverat a specific git ref 1. callkubectl kustomizein themetrics-serverdirectorykustomization.yamlfile in themetrics-serverdirectory
kustomization.yamlfile points at example deployment manifests inthe cloned
kubernetes-incubator/metrics-serverdirectorykustomization.yamlpatches the upstream example deploymentmanifests with settings similar to what came with the
helmchart 1. justlike before, wait until the
metrics-serverpod(s) are readyOne major difference from the
helmchart is that withhelmit was easyto deploy
metrics-serverto its own namespace whereas the upstreamexample manifests on which the
kustomizeapproach is based assumedeployment in
kube-system. It wasn't straightforward to usekustomizepatches or bases to do something similar -- I'm sure it's possible, I just
haven't found the minimal set of patches necessary yet.