Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1825790 Implement safer file based token cache #1327

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Mar 6, 2025

Description

SNOW-1825790 Implement safer file based token cache

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 74.58194% with 76 lines in your changes missing coverage. Please review.

Project coverage is 81.90%. Comparing base (8ed4c75) to head (ffad6d7).

Files with missing lines Patch % Lines
secure_storage_manager.go 76.17% 66 Missing ⚠️
os_specific_posix.go 66.66% 6 Missing ⚠️
os_specific_windows.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
- Coverage   82.09%   81.90%   -0.19%     
==========================================
  Files          55       57       +2     
  Lines       13724    13902     +178     
==========================================
+ Hits        11267    11387     +120     
- Misses       2457     2515      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review March 7, 2025 06:21
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner March 7, 2025 06:21
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from 0355860 to 0203aa6 Compare March 7, 2025 06:25
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from 0203aa6 to 577ce1c Compare March 7, 2025 07:31
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from a506ebf to 506100d Compare March 7, 2025 12:44
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from ca3f08e to 8a47a67 Compare March 12, 2025 07:12
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from e86061f to ffad6d7 Compare March 12, 2025 10:15
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-1825790-token-cache branch from 85e9742 to c72f84b Compare March 13, 2025 08:08
Copy link

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants