-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1825790 Implement safer file based token cache #1327
Open
sfc-gh-pfus
wants to merge
12
commits into
master
Choose a base branch
from
SNOW-1825790-token-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+619
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 82.09% 81.90% -0.19%
==========================================
Files 55 57 +2
Lines 13724 13902 +178
==========================================
+ Hits 11267 11387 +120
- Misses 2457 2515 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0355860
to
0203aa6
Compare
0203aa6
to
577ce1c
Compare
a506ebf
to
506100d
Compare
9cbbb9a
to
ca3f08e
Compare
2 tasks
ca3f08e
to
8a47a67
Compare
e86061f
to
ffad6d7
Compare
This was referenced Mar 13, 2025
85e9742
to
c72f84b
Compare
sfc-gh-jszczerbinski
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sfc-gh-astachowski
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1825790 Implement safer file based token cache
Checklist