-
Notifications
You must be signed in to change notification settings - Fork 143
SNOW-2208205: Testing support for RHEL9 #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This reverts commit a81b1f9.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
+ Coverage 89.49% 89.54% +0.04%
==========================================
Files 91 91
Lines 8043 8043
Branches 119 119
==========================================
+ Hits 7198 7202 +4
+ Misses 829 825 -4
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| child.on('exit', () => {}); | ||
| const wireMock = new WireMockRestClient(`http://localhost:${port}`, { | ||
| // Use 127.0.0.1 instead of localhost to avoid IPv6/IPv4 resolution issues on Node.js 18 + RHEL9 | ||
| const wireMock = new WireMockRestClient(`http://127.0.0.1:${port}`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we can just pass a port and concatenate in constructor to avoid someone unknowingly providing localhost
Description
SNOW-2208205: Testing support for RHEL9
Checklist
npm run test:unitandnpm run test:integration)