You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enabling isSecretsEnabled by default in featureFlagDefaults affects all acceptance tests in the repository that use the fakeServer. The existing comment in this file explicitly states that features should be enabled specifically by tests that target them. By making this a global default, other tests that do not expect or mock secrets-related API calls may fail when the CLI attempts to communicate with those endpoints.
In Scenario 4 (mid-execution-maintenance), the test sets the next status code to 200 for 4 requests without providing mock response bodies. CLI commands like test or monitor typically expect valid JSON from their initial API calls (e.g., for organization or user verification). If these calls return an empty 200 response, the CLI will fail with a JSON parsing error before reaching the maintenance failure state, causing the test to fail with an incorrect exit code.
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to enable this only in the tests, to avoid doing this globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
are release-note ready, emphasizing
what was changed, not how.
What does this PR do?
This PR moves existing separate tests into a single test suite for easier overview and maintenance.
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?
N/A
Risk assessment (Low | Medium | High)?
Low, changes tests only