Skip to content

chore: revert linux static e2e#6826

Open
CatalinSnyk wants to merge 2 commits into
release/1.1305from
chore/revert-linux-static_e2e
Open

chore: revert linux static e2e#6826
CatalinSnyk wants to merge 2 commits into
release/1.1305from
chore/revert-linux-static_e2e

Conversation

@CatalinSnyk
Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk commented May 20, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This is a prepared rollback PR in case there should be any regression with statically linked linux binaries

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

@CatalinSnyk CatalinSnyk requested review from a team as code owners May 20, 2026 13:02
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 20, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Broken Path 🟠 [major]

The removal of the V1_BINARY_SUBFOLDER = experimental/ conditional logic will cause static binaries to be output directly into the root binary folder. However, the .circleci/config.yml still contains active jobs like acceptance-tests linux static arm64 that expect the binary at ./binary-releases/experimental/snyk-linux-arm64. This mismatch will cause the CI pipeline to fail during the acceptance test phase for remaining static build jobs.

V1_BUILD_TYPE = build:prod
V1_BINARY_FOLDER = ts-cli-binaries
# default to empty string, which means no subfolder
V1_BINARY_SUBFOLDER =
HASH_STRING = $(HASH)$(HASH_ALGORITHM)
SIGN_SCRIPT = $(WORKING_DIR)/scripts/sign_$(_GO_OS).sh
ISSIGNED_SCRIPT = $(WORKING_DIR)/scripts/issigned_$(_GO_OS).sh
EMBEDDED_DATA_DIR = $(WORKING_DIR)/internal/embedded/_data
📚 Repository Context Analyzed

This review considered 12 relevant code sections from 11 files (average relevance: 0.69)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants