fix: handle 'none' severity in getSeverityValue, drop duplicate assignment in handleError#6849
Open
immanuwell wants to merge 1 commit into
Open
fix: handle 'none' severity in getSeverityValue, drop duplicate assignment in handleError#6849immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
…assignment in handleError
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small bugs fixed:
1.
getSeverityValuecrashes on'none'severityThe function signature accepts
SEVERITY | 'none', but'none'isn't in theSEVERITIESarray. The!non-null assertion turns that missing entry into a runtimeTypeError.Reproduce:
IaC code already treats
'none'as a real severity value (seeresults-formatter.tsfilteringviolatedPolicy.severity !== 'none'), so this path is reachable. Fix: swap!.valuefor?.value ?? 0— returns 0 for'none', which fits naturally belowlow(1).2. Duplicate assignment in
handleErrorerror.userMessage = error.nestedUserMessage || error.userMessageappears twice in a row (lines 99 and 102), no mutation between them. Second line is dead code, introduced as a copy-paste leftover.Changes
src/lib/formatters/get-severity-value.ts: replace unsafe non-null assertion with optional chaining + nullish coalescingsrc/cli/main.ts: remove duplicateuserMessageassignmenttest/jest/unit/lib/formatters/get-severity-value.spec.ts: add test case for'none'input