fix: apply invocation config to workflow Data after callback#606
Open
danskmt wants to merge 1 commit into
Open
fix: apply invocation config to workflow Data after callback#606danskmt wants to merge 1 commit into
danskmt wants to merge 1 commit into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
CatalinSnyk
reviewed
May 12, 2026
b804c2c to
2bb8c90
Compare
This comment has been minimized.
This comment has been minimized.
2bb8c90 to
89017c8
Compare
This comment has been minimized.
This comment has been minimized.
89017c8 to
86de328
Compare
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workflows can return
Datacreated withworkflow.NewDatawithoutWithConfiguration, soIN_MEMORY_THRESHOLD_BYTESandTEMP_DIR_PATHwere not applied to those payloads.After each workflow callback returns,
EngineImpl.InvokecallsapplyConfigurationon each*DataImplin the output slice so in-memory payloads can spill to the configured temp directory when above threshold.applyConfigurationis package-private onDataImpl(same package as the engine) so it is not exported from the workflow package.Adds tests in
dataimpl_test.gofor spill and no-op cases, and inengine_test.gofor behavior afterInvoke.Checklist
make test)make generate)make lint)go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMITin thecliv2directory.go.modto point to your local GAF code.go mod tidyin thecliv2directory.go.modandgo.sumchanges.PR in CLI snyk/cli#6792
Where reviewers should start
pkg/workflow/dataimpl.go—applyConfigurationpkg/workflow/engineimpl.go— post-process loop aftercallbackRisk assessment
Low. Default production behavior is unchanged unless spill-related settings are enabled; when they are, returned
Dataplacement aligns with engine configuration instead of leaving eligible payloads in memory.