fix(sofa-checkout-service): Changed wrong paramater

[knitzie]

The parameter checkoutModel.payment seems to be null during checkout, checkoutModel.selectedPaymentMethod is filled

[0x-r4bbit]

@sofa anybody in charge for this? I think @CrashKid or @cburgdorf is familiar with the checkout.

[CrashKid]

As of cda03ab the payment parameter was an intended change. I'd like us to pass any model as clean as possible to the backend. And the selectedPaymentMethod is a mess...
Have a look at https://github.com/couchcommerce/private-sofa-app/blob/reno/src/app/checkout/CheckoutController.js#L244-L253 to see how I fill the new payment object

[0x-r4bbit]

@CrashKid This link is private.

[CrashKid]

Sure it is. It was meant for @knitzie exclusively.
The solution is to pass a payment object, which has to look like this:

return {
    methodCode: 'code', // method code of the selected payment method
    methodDetails: {}, // selected payment method's extraField data (optional)
    successUrl: 'checkoutSuccessUrl', // (optional)
    errorUrl: 'checkoutErrorUrl' // (optional)
};

[knitzie]

Ah ok, thanks for the advice @CrashKid :)