Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization and deserialization classloader issues in serverless scene #1484

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public ClientStreamObserverAdapter(SofaStreamObserver<Object> sofaStreamObserver
@Override
public void onNext(triple.Response response) {
byte[] responseData = response.getData().toByteArray();
Object appResponse = null;
Object appResponse;
String returnTypeName = response.getType();
if (responseData != null && responseData.length > 0) {
ClassLoader oldClassloader = Thread.currentThread().getContextClassLoader();
Expand All @@ -64,24 +64,35 @@ public void onNext(triple.Response response) {
returnType = Class.forName(returnTypeName, true, classLoader);
}
appResponse = serializer.decode(new ByteArrayWrapperByteBuf(responseData), returnType, null);
sofaStreamObserver.onNext(appResponse);
} catch (ClassNotFoundException e) {
throw new SofaRpcException(RpcErrorType.CLIENT_DESERIALIZE, "Can not find return type :" + returnType,
e);
} finally {
Thread.currentThread().setContextClassLoader(oldClassloader);
}
}

sofaStreamObserver.onNext(appResponse);
}

@Override
public void onError(Throwable t) {
sofaStreamObserver.onError(t);
ClassLoader oldClassloader = Thread.currentThread().getContextClassLoader();
try {
Thread.currentThread().setContextClassLoader(classLoader);
sofaStreamObserver.onError(t);
} finally {
Thread.currentThread().setContextClassLoader(oldClassloader);
}
}

@Override
public void onCompleted() {
sofaStreamObserver.onCompleted();
ClassLoader oldClassloader = Thread.currentThread().getContextClassLoader();
try {
Thread.currentThread().setContextClassLoader(classLoader);
sofaStreamObserver.onCompleted();
} finally {
Thread.currentThread().setContextClassLoader(oldClassloader);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -131,20 +131,37 @@ public StreamObserver<Request> genericBiStream(StreamObserver<Response> response

@Override
public void onNext(Request request) {
checkInitialize(request);
Object message = getInvokeArgs(request, argTypes, serializer, false)[0];
serverResponseHandler.setSerializeType(serializeType);
clientHandler.onNext(message);
try {
Thread.currentThread().setContextClassLoader(serviceClassLoader);
checkInitialize(request);
Object message = getInvokeArgs(request, argTypes, serializer, false)[0];
serverResponseHandler.setSerializeType(serializeType);
clientHandler.onNext(message);
} finally {
Thread.currentThread().setContextClassLoader(oldClassLoader);
}
}

@Override
public void onError(Throwable t) {
clientHandler.onError(t);
try {
Thread.currentThread().setContextClassLoader(serviceClassLoader);
clientHandler.onError(t);
} finally {
Thread.currentThread().setContextClassLoader(oldClassLoader);
}

}

@Override
public void onCompleted() {
clientHandler.onCompleted();
try {
Thread.currentThread().setContextClassLoader(serviceClassLoader);
clientHandler.onCompleted();
} finally {
Thread.currentThread().setContextClassLoader(oldClassLoader);
}

}

private void checkInitialize(Request request) {
Expand Down
Loading