Fix hurry ahead bug + Performance Possible Moves#91
Merged
Conversation
maxblan
requested changes
May 30, 2025
src/plugin/action/card.rs
Outdated
| ) -> Result<(), PyErr> { | ||
| let distance = target_position as isize - player.position as isize; | ||
|
|
||
| if target_position == 64 && (player.carrots > 10 || player.salads > 0) { |
Collaborator
There was a problem hiding this comment.
This should target_position == 64 && player.carrots > 10 && player.salads > 0, right?
The documentation writes the following:
Das Zielfeld darf nur betreten werden, wenn der Spieler höchstens zehn Karotten und keinen Salat besitzt.
I'm currently not 100% sure, but is the index of the goal not at 65? At least the constants.rs says so. Please verify.
Put these numbers in the constants.rs.
Collaborator
Author
There was a problem hiding this comment.
it is 64, the index starts at 0, so we got the 65 in the constants... I used it like in hare.rs:72
(like in hare.rs:72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performance Possible Moves:
Some team made the discovery that the possible moves are extremly slow when handling cards (due to permutations)
-> made a much faster perform move which still generates the same moves (tested with eq() method)
-> kept old possible moves but renamed as reference and if somebody still wants to use it
Hurry Ahead Bug:
On some rare and weird occasions there where possible hurry ahead moves into goal violating the rules engine
-> added small and dirty fix
-> fix in rules engine always broke some other piece of code, therefore the small edge case fix
Type of change
How Has This Been Tested?
Old and newly added tests
Via playing HUI
Checklist: