Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LLM message history #104

Merged
merged 5 commits into from
Feb 24, 2025
Merged

feat: LLM message history #104

merged 5 commits into from
Feb 24, 2025

Conversation

jakmro
Copy link
Member

@jakmro jakmro commented Feb 23, 2025

Description

Add LLM message history

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro marked this pull request as ready for review February 24, 2025 11:44
@@ -13,6 +14,7 @@ export class LLMModule {
modelSource: ResourceSource,
tokenizerSource: ResourceSource,
systemPrompt = DEFAULT_SYSTEM_PROMPT,
messageHistory = DEFAULT_MESSAGE_HISTORY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change order of arguments, messageHistory should be after contextWindowLength

@jakmro jakmro merged commit f1bfd5e into main Feb 24, 2025
2 checks passed
@jakmro jakmro deleted the @jakmro/llm-message-history branch February 24, 2025 15:38
jakmro added a commit that referenced this pull request Mar 5, 2025
## Description
Add LLM message history

### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on
- [x] iOS
- [x] Android

### Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants