Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-commit code formatting #107

Merged
merged 6 commits into from
Mar 10, 2025
Merged

feat: pre-commit code formatting #107

merged 6 commits into from
Mar 10, 2025

Conversation

jakmro
Copy link
Member

@jakmro jakmro commented Feb 25, 2025

Description

Add pre-commit code formatting

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@jakmro jakmro changed the title @jakmro/code formatting feat: pre-commit code formatting Feb 25, 2025
@jakmro jakmro marked this pull request as ready for review February 25, 2025 11:02
Copy link
Contributor

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip decoders directory it contains huge files that don't really need formatting, analogously to this:

"lint": "eslint \"**/*.{js,ts,tsx}\" --ignore-pattern src/decoders/",

WDYT?

@jakmro
Copy link
Member Author

jakmro commented Mar 3, 2025

I think we can skip decoders directory it contains huge files that don't really need formatting, analogously to this:

"lint": "eslint \"**/*.{js,ts,tsx}\" --ignore-pattern src/decoders/",

WDYT?

It works only on staged files so it should be fine ⚡

@jakmro jakmro force-pushed the @jakmro/code-formatting branch from ccae237 to c922e54 Compare March 7, 2025 17:52
@jakmro jakmro requested a review from chmjkb March 10, 2025 10:37
@jakmro jakmro merged commit ad69dc5 into main Mar 10, 2025
3 checks passed
@jakmro jakmro deleted the @jakmro/code-formatting branch March 10, 2025 10:56
JakubGonera pushed a commit that referenced this pull request Mar 12, 2025
## Description
Add pre-commit code formatting

### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update (improves or adds clarity to existing
documentation)

### Tested on
- [x] iOS
- [x] Android

### Checklist
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly
- [x] My changes generate no new warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants