feat: implemented vertical ocr #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakmro
requested changes
Feb 27, 2025
android/src/main/java/com/swmansion/rnexecutorch/models/ocr/utils/DetectorUtils.kt
Outdated
Show resolved
Hide resolved
...-vision/node_modules/react-native-executorch/ios/RnExecutorch/models/ocr/VerticalDetector.mm
Show resolved
Hide resolved
|
|
||
| } | ||
|
|
||
| - (void)forward:(NSString *)input |
There was a problem hiding this comment.
Also here I would put some of the logic inside something like RecognitionHandler in horizontal OCR to make it more maintainable
There was a problem hiding this comment.
I was thinking about it, however whole ocr consists of many files already and I felt like adding another file which will be only wrapper won't help that much.
| } | ||
| } | ||
|
|
||
| override fun forward(input: String, promise: Promise) { |
There was a problem hiding this comment.
I would put some of the logic inside something like recognitionHandler in horizontal OCR to make it more maintainable
There was a problem hiding this comment.
I was thinking about it, however whole ocr consists of many files already and I felt like adding another file which will be only wrapper won't help that much.
jakmro
reviewed
Mar 3, 2025
jakmro
reviewed
Mar 4, 2025
jakmro
reviewed
Mar 4, 2025
jakmro
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes