Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Image segmentation for ios #113
base: main
Are you sure you want to change the base?
feat: Image segmentation for ios #113
Changes from 1 commit
e73648c
147b929
b9bc989
0eb1cdd
9952bf3
f0b12ea
3d03e08
112511b
5dbf576
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should use this or keyof typeof DeeplabLabel. Using keyof typeof would make it consistent, since it is used in object detection but I think i like this one better. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't notice the use in object detection, but I would still make the case for this. In object detection the enum is used as a return value, so we're just interested in the string content, whereas here the enum is supplied by the user (in both cases, either as the filter for classes in a list, or as the key to query results in the dict), so we care more about correctness. I think that autocompletion for the enum values when writing is worth more than consistency in this case.