Remove abstract pre/postprocess from BaseModel #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubGonera
force-pushed
the
@jakubgonera/remove-abstract-pre-post-process
branch
from
bcac318 to
59e2fbf
Compare
NorbertKlockiewicz
requested changes
Mar 10, 2025
android/src/main/java/com/swmansion/rnexecutorch/models/speechToText/BaseS2TDecoder.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnexecutorch/models/speechToText/MoonshineEncoder.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnexecutorch/models/speechToText/WhisperEncoder.kt
Outdated
Show resolved
Hide resolved
NorbertKlockiewicz
approved these changes
Mar 10, 2025
JakubGonera
added a commit
that referenced
this pull request
Mar 12, 2025
## Description Remove abstract pre/postprocess methods from BaseModel in native Android code. The methods are always called on concrete classes so it's not necessary for them to be abstract. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [x] Android ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings --------- Co-authored-by: Jakub Gonera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove abstract pre/postprocess methods from BaseModel in native Android code. The methods are always called on concrete classes so it's not necessary for them to be abstract.
Type of change
Tested on
Checklist