fix: make react-native-audio-api a peer dependency #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertKlockiewicz
approved these changes
Mar 7, 2025
mkopcins
requested changes
Mar 7, 2025
Comment on lines
+59
to
+60
| If you encountered an error that native modules for React Native Audio API were not installed, please make sure to install react-native-audio-api. | ||
| ::: |
There was a problem hiding this comment.
Suggested change
| If you encountered an error that native modules for React Native Audio API were not installed, please make sure to install react-native-audio-api. | |
| ::: | |
| If you encountered an error that native modules for React Native Audio API were not installed, please make sure to run `yarn add react-native-audio-api`. | |
| ::: |
There was a problem hiding this comment.
Not sure if I think its better, not everyone uses yarn
There was a problem hiding this comment.
we use yarn above in docs, that's why i opted for this, but it is not necessary
Co-authored-by: Norbert Klockiewicz <[email protected]>
mkopcins
approved these changes
Mar 7, 2025
JakubGonera
pushed a commit
that referenced
this pull request
Mar 12, 2025
## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [ ] iOS - [ ] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Norbert Klockiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the need of manually installing audio api more explicit
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes