Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter & CI fixes #5

Merged
merged 6 commits into from
Nov 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 0 additions & 118 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,6 @@ jobs:
- name: Typecheck files
run: yarn typecheck

test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup
uses: ./.github/actions/setup

- name: Run unit tests
run: yarn test --maxWorkers=2 --coverage

build-library:
runs-on: ubuntu-latest
steps:
Expand All @@ -49,109 +37,3 @@ jobs:

- name: Build package
run: yarn prepare

build-android:
runs-on: ubuntu-latest
env:
TURBO_CACHE_DIR: .turbo/android
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup
uses: ./.github/actions/setup

- name: Cache turborepo for Android
uses: actions/cache@v3
with:
path: ${{ env.TURBO_CACHE_DIR }}
key: ${{ runner.os }}-turborepo-android-${{ hashFiles('yarn.lock') }}
restore-keys: |
${{ runner.os }}-turborepo-android-

- name: Check turborepo cache for Android
run: |
TURBO_CACHE_STATUS=$(node -p "($(yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:android').cache.status")

if [[ $TURBO_CACHE_STATUS == "HIT" ]]; then
echo "turbo_cache_hit=1" >> $GITHUB_ENV
fi

- name: Install JDK
if: env.turbo_cache_hit != 1
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: '17'

- name: Finalize Android SDK
if: env.turbo_cache_hit != 1
run: |
/bin/bash -c "yes | $ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager --licenses > /dev/null"

- name: Cache Gradle
if: env.turbo_cache_hit != 1
uses: actions/cache@v3
with:
path: |
~/.gradle/wrapper
~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('example/android/gradle/wrapper/gradle-wrapper.properties') }}
restore-keys: |
${{ runner.os }}-gradle-

- name: Build example for Android
env:
JAVA_OPTS: "-XX:MaxHeapSize=6g"
run: |
yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}"

build-ios:
runs-on: macos-14
env:
TURBO_CACHE_DIR: .turbo/ios
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Setup
uses: ./.github/actions/setup

- name: Cache turborepo for iOS
uses: actions/cache@v3
with:
path: ${{ env.TURBO_CACHE_DIR }}
key: ${{ runner.os }}-turborepo-ios-${{ hashFiles('yarn.lock') }}
restore-keys: |
${{ runner.os }}-turborepo-ios-

- name: Check turborepo cache for iOS
run: |
TURBO_CACHE_STATUS=$(node -p "($(yarn turbo run build:ios --cache-dir="${{ env.TURBO_CACHE_DIR }}" --dry=json)).tasks.find(t => t.task === 'build:ios').cache.status")

if [[ $TURBO_CACHE_STATUS == "HIT" ]]; then
echo "turbo_cache_hit=1" >> $GITHUB_ENV
fi

- name: Cache cocoapods
if: env.turbo_cache_hit != 1
id: cocoapods-cache
uses: actions/cache@v3
with:
path: |
**/ios/Pods
key: ${{ runner.os }}-cocoapods-${{ hashFiles('example/ios/Podfile.lock') }}
restore-keys: |
${{ runner.os }}-cocoapods-

- name: Install cocoapods
if: env.turbo_cache_hit != 1 && steps.cocoapods-cache.outputs.cache-hit != 'true'
run: |
cd example/ios
pod install
env:
NO_FLIPPER: 1

- name: Build example for iOS
run: |
yarn turbo run build:ios --cache-dir="${{ env.TURBO_CACHE_DIR }}"
4 changes: 3 additions & 1 deletion .github/workflows/docs-build-check.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
name: Check documentation

on:
pull_request:
push:
branches:
- main
paths:
- 'docs/**'
workflow_dispatch:
Expand Down
10 changes: 6 additions & 4 deletions docs/docusaurus.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const lightCodeTheme = require('./src/theme/CodeBlock/highlighting-light.js');
const darkCodeTheme = require('./src/theme/CodeBlock/highlighting-dark.js');
// @ts-check
const webpack = require('webpack');

Check warning on line 4 in docs/docusaurus.config.js

View workflow job for this annotation

GitHub Actions / lint

'webpack' is assigned a value but never used

/** @type {import('@docusaurus/types').Config} */
const config = {
Expand All @@ -27,7 +27,8 @@
breadcrumbs: false,
sidebarPath: require.resolve('./sidebars.js'),
sidebarCollapsible: false,
editUrl: 'https://github.com/software-mansion/react-native-executorch/edit/main/docs',
editUrl:
'https://github.com/software-mansion/react-native-executorch/edit/main/docs',
},
theme: {
customCss: require.resolve('./src/css/index.css'),
Expand All @@ -53,9 +54,10 @@
},
items: [
{
href: 'https://github.com/software-mansion/react-native-executorch',
position: 'right',
className: 'header-github',
'href':
'https://github.com/software-mansion/react-native-executorch',
'position': 'right',
'className': 'header-github',
'aria-label': 'GitHub repository',
},
],
Expand Down
2 changes: 1 addition & 1 deletion docs/sidebars.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/** @type {import('@docusaurus/plugin-content-docs').SidebarsConfig} */
const sidebars = {
// By default, Docusaurus generates a sidebar from the docs folder structure
tutorialSidebar: [{type: 'autogenerated', dirName: '.'}],
tutorialSidebar: [{ type: 'autogenerated', dirName: '.' }],

// But you can create a sidebar manually
/*
Expand Down
3 changes: 2 additions & 1 deletion docs/src/components/Hero/StartScreen/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ const StartScreen = () => {
<span>ExecuTorch</span>
</h1>
<h2 className={styles.subheadingLabel}>
Declarative way to run AI models in React Native on device, powered by ExecuTorch.
Declarative way to run AI models in React Native on device, powered
by ExecuTorch.
</h2>
</div>
<div className={styles.lowerHeading}>
Expand Down
3 changes: 2 additions & 1 deletion docs/src/components/HomepageButton/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ const HomepageButton: React.FC<{
styles.homepageButton,
backgroundStyling,
borderStyling
)}>
)}
>
{title}

<div className={styles.arrow}>
Expand Down
5 changes: 3 additions & 2 deletions docs/src/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ function Home() {
return (
<Layout
title={`React Native ExecuTorch`}
description="Declarative way to run AI models in React Native on device, powered by ExecuTorch.">
description="Declarative way to run AI models in React Native on device, powered by ExecuTorch."
>
<div className={styles.container}>
<HomepageStartScreen />
</div>
Expand Down Expand Up @@ -45,4 +46,4 @@ function Home() {
);
}

export default Home;
export default Home;
2 changes: 1 addition & 1 deletion examples/llama/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { SafeAreaProvider } from 'react-native-safe-area-context';
import ChatScreen from './screens/ChatScreen';

export default function App() {
const fontsLoaded = useFonts({
useFonts({
medium: require('./assets/fonts/Aeonik-Medium.otf'),
regular: require('./assets/fonts/Aeonik-Regular.otf'),
});
Expand Down
6 changes: 2 additions & 4 deletions examples/llama/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
module.exports = function(api) {
module.exports = function (api) {
api.cache(true);
return {
presets: ['babel-preset-expo'],
plugins: [
'react-native-reanimated/plugin'
]
plugins: ['react-native-reanimated/plugin'],
};
};
10 changes: 5 additions & 5 deletions examples/llama/metro.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { getDefaultConfig } = require("expo/metro-config");
const { getDefaultConfig } = require('expo/metro-config');

module.exports = (() => {
const config = getDefaultConfig(__dirname);
Expand All @@ -7,14 +7,14 @@ module.exports = (() => {

config.transformer = {
...transformer,
babelTransformerPath: require.resolve("react-native-svg-transformer/expo"),
babelTransformerPath: require.resolve('react-native-svg-transformer/expo'),
};
config.resolver = {
...resolver,
assetExts: resolver.assetExts.filter((ext) => ext !== "svg"),
sourceExts: [...resolver.sourceExts, "svg"],
assetExts: resolver.assetExts.filter((ext) => ext !== 'svg'),
sourceExts: [...resolver.sourceExts, 'svg'],
};

config.resolver.assetExts.push('pte');
config.resolver.assetExts.push('bin');

Expand Down
8 changes: 8 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,14 @@
}
},
"eslintConfig": {
"parserOptions": {
"requireConfigFile": false,
"babelOptions": {
"presets": [
"@babel/preset-react"
]
}
},
"root": true,
"extends": [
"@react-native",
Expand Down
Binary file added react-native-executorch-0.1.0.tgz
Binary file not shown.
Loading