feat: ocr(ios) #84
Merged
feat: ocr(ios) #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertKlockiewicz
changed the title
mkopcins
requested changes
Jan 30, 2025
| @@ -71,6 +71,19 @@ const StyleTransfer = StyleTransferSpec | |||
| } | |||
| ); | |||
|
|
|||
| const OCRSpec = require('./NativeOCR').default; | |||
There was a problem hiding this comment.
We should also implement hookless api for OCR
There was a problem hiding this comment.
I think it will be best to add it when this pr is merged to branch with hookles api already implemented
mkopcins
requested changes
Feb 10, 2025
mkopcins
approved these changes
Feb 18, 2025
…imilar result to original version
… in returned object
…to ImageProcessor
…to changes suggested in review
<!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] iOS - [x] Android <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> <!-- Add screenshots here, if applicable --> <!-- Link related issues here using #issue-number --> - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [x] My changes generate no new warnings <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
NorbertKlockiewicz
force-pushed
the
@norbertklockiewicz/ocr-implementation
branch
from
42cc379 to
9538fbf
Compare
NorbertKlockiewicz
deleted the
@norbertklockiewicz/ocr-implementation
branch
jakmro
pushed a commit
that referenced
this pull request
Mar 5, 2025
## Description <!-- Provide a concise and descriptive summary of the changes implemented in this PR. --> ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) ### Tested on - [x] iOS - [x] Android ### Testing instructions <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> ### Screenshots <!-- Add screenshots here, if applicable --> ### Related issues <!-- Link related issues here using #issue-number --> ### Checklist - [x] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings ### Additional notes <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes