Skip to content

Conversation

@patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Oct 23, 2025

Summary

This PR adds support for filter property. Before it was only supported on web.

It adds processFilter function, adjusts web implementation of this function and changes the name to processFilterWeb. I've also added some tests. The filter property is also added to native CSS props.

TO-DO:

Important

Disclaimer sometimes there is a problem with precision as the outcome is for example 3.237473234e-14px and it is non parsable - maybe we can change global precision to some defined number of decimal points, or locally I can change it inside filter function.

Important

Disclaimer 2 sometimes we the static asset does not work (most of the time) and it's not related to the filter processing, when testing please replace balloonsImage with some working uri. The asset problem will be fixed in some other PR.

Test plan

  1. Build app across platforms.
  2. Test Animate Filter example in Reanimated App on Android, iOS and Web.
  3. Run tests.

@patrycjakalinska patrycjakalinska marked this pull request as ready for review October 28, 2025 09:58
Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. In general, good job! I like the tests part very much, they are super clean!

Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my previous comments. I left a few other comments. I think that the PR will be good to merge after addressing the new bunch of comments.

Copy link
Member

@MatiPl01 MatiPl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrycjakalinska patrycjakalinska added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 9347064 Nov 3, 2025
12 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/filter-property-integration branch November 3, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants