-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(Worklets): Worklet Runtime C++ scheduling API #8456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+260
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tomekzaw
reviewed
Nov 7, 2025
packages/react-native-worklets/Common/cpp/worklets/SharedItems/Serializable.h
Outdated
Show resolved
Hide resolved
bartlomiejbloniarz
approved these changes
Nov 18, 2025
packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.cpp
Show resolved
Hide resolved
packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.h
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #8425
I'm adding scheduling APIs for the
WorkletRuntimeclass resembling the ones in TypeScript API. I preserved previous scheduling APIs as deprecated.Synchronous call methods
jsi::Functionorstd::shared_ptr<SerializableWorklet>runOn...SyncTS API etc.callGuardjsi::Valuejsi::Runtime &as an argument, i.e.std::function<TReturn(jsi::Runtime &)>runOn...SyncTS API etc.callGuard- the user have to do it themselvesrunSyncbut returns extractedSerializablefromjsi::ValuecreateSerializablestd::function<TReturn(jsi::Runtime &)>asTReturnmight not be serializableAsynchronous call methods
scheduleOn...TS API etc.jsi::Function,std::shared_ptr<SerializableWorklet>,std::function<void()>orstd::function<void(jsi::Runtime&)>AsyncQueuesetjsi::Functionandstd::shared_ptr<SerializableWorklet>we don't want to be responsible for how arguments are stored in the lambda passed toAsyncQueuestd::functionthe user can store the arguments in their lambdarunAsyncfunction possibly returning promises (futures) is yet to be considered for implementation in future PRsDeprecated methods
runGuarded- identical torunSync, replaced withrunSyncrunAsyncGuarded- identical toschedule, replaced withscheduleexecuteSync- this function was a bit complicated. It took two runtimes, executed a worklet on the target runtime then serialized data back to the caller runtime. While it's a handy syntax sugar I think it shouldn't be a method of a runtime but rather some utility API. Replaced withrunSyncSerializedand manual extraction on the caller runtime.executeSync- identical torunSyncreplaced withrunSyncTest plan
⭐ BokehExample ⭐