[ts-sdk] Add Blob as MP4 input
#1007
Conversation
There was a problem hiding this comment.
This was not used by any example, but MultipleOutputs had pretty much the same implementation so I put everything here
| | Api.RegisterInput | ||
| | { type: 'mp4_blob'; blob: any } |
There was a problem hiding this comment.
Api.RegisterInput is a generated type and already contains definitions for mp4; hence, the new type mp4_blob
There was a problem hiding this comment.
I don't like adding new type just for that, it might make sense if it was more generic to handle some other cases types in the future, but not in this form
There was a problem hiding this comment.
I don't think this will work with Mp4 components. Is it?
I don't like the idea of just patching additional input type that would only work in wasm just to handle this one specific. I would consider first a more generic/future-proof approach, and only go with this approach if there is no other choice
| | Api.RegisterInput | ||
| | { type: 'mp4_blob'; blob: any } |
There was a problem hiding this comment.
I don't like adding new type just for that, it might make sense if it was more generic to handle some other cases types in the future, but not in this form
| @@ -23,7 +23,11 @@ export async function handleRegisterInputRequest( | |||
| ): Promise<RegisterInputResult> { | |||
| if (body.type === 'mp4') { | |||
| assert(body.url, 'mp4 URL is required'); | |||
| return handleRegisterMp4Input(ctx, inputId, body.url); | |||
| const arrayBuffer = await downloadToArrayBuffer(body.url); | |||
There was a problem hiding this comment.
the whole point of having functions like handleRegisterMp4Input is to separate mp4-specific code from common code.
Preparing an array buffer here only unnecessarily complicates this function which should be only a simple if-else tree to call appropriate handlers. Additionally, it spreads potential functions that can throw an error all over the place.
| export async function downloadToArrayBuffer(url: string): Promise<ArrayBuffer> { | ||
| const response = await fetch(url); | ||
| return await response.arrayBuffer(); | ||
| } |
There was a problem hiding this comment.
in my opinion this util is not helpful
Closes #1001