[ts-sdk] Make shaders work on web #996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noituri
force-pushed
the
@noituri/make-shaders-work-wasm
branch
from
c820f8c to
f377c89
Compare
noituri
commented
Mar 5, 2025
| plane_id: i32, | ||
| time: f32, | ||
| output_resolution: vec2<u32>, | ||
| texture_count: u32, |
There was a problem hiding this comment.
I'm not sure if texture_count is needed here. Currently, we only allow one texture but in the future we might support more. The same goes for plane_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaders on web have to be slightly different from the native version, because we can't use
binding_arrayon web.Due to those limitations, on the web, we'll only allow one texture to be passed to the user shader
Closes: #701