feat: dual-era datatypes and server handling for 2026-07-28 (T4, T8) - #260
Open
sideeffffect wants to merge 2 commits into
Open
sideeffffect wants to merge 2 commits into
sideeffffect wants to merge 2 commits into
Conversation
This was referenced Sep 14, 2026
Closed
Collaborator
|
The T1, T2 PR is merged now. I took a first look and I am missing updates to server conformance tests, will you look into that as well? Agent does a good job on them as long as he has access to it's sources, described in |
Stacked on top of softwaremill#238 (T1 + T2). Carries the parts moved out of that PR at review request: T4 (softwaremill#242) - request metadata, result type, cache hints, error codes, discover types: - Versioning.scala: ProtocolMeta, CacheScope, DiscoverResult (+ getSupportedVersions) - JSONRPCErrorCodes.UnsupportedProtocolVersion (-32022) - ProtocolVersion.supported / isModern - DiscoverResultSpec + DiscoverResult / UnsupportedProtocolVersionError schema conformance T8 (softwaremill#246) - serve 2026-07-28 requests next to legacy requests: - McpHandler: server/discover, per-request modern-version validation, dual-era dispatch - McpHandlerSpec: discover, -32022, modern and legacy-path coverage - docs/server/capabilities.md Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
sideeffffect
force-pushed
the
feat/protocol-2026-07-28-server
branch
from
September 16, 2026 16:59
60aef3f to
b574dd5
Compare
Wrap 2026-07-28 results with the modern envelope (resultType: complete, serverInfo in _meta; cacheable results also carry ttlMs and cacheScope) so the server passes the modern tools/list, tools/call, resources/*, prompts/*, completion and caching conformance scenarios. Wire the server conformance harness for 2026-07-28: a per-spec-version baseline (conformance-baseline-<version>.yml) selected by the sbt task, a conformance-baseline-2026-07-28.yml capturing the scenarios that still need later tickets (tasks/MRTR and input-required → T5 softwaremill#243; full stateless lifecycle and modern HTTP header validation), and a CI step running it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Author
|
Done — rebased onto the merged T1/T2 base (the earlier conflict is gone) and added the server conformance updates. Server conformance for 2026-07-28:
Verified locally: 2026-07-28 server conformance passes (all remaining failures are the baselined ones); 2025-11-25 stays green (63 passed, 4 expected) — no regression. |
sideeffffect
changed the title
sideeffffect
marked this pull request as ready for review
September 17, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #238 (T1 + T2, now merged). Targets
2026-07-28-protocol-support.Closes #242.
Closes #246.
T4 — #242: request metadata, result type, cache hints, error codes, discover types
Versioning.scala:ProtocolMeta,CacheScope,DiscoverResult(+getSupportedVersions)JSONRPCErrorCodes.UnsupportedProtocolVersion(-32022)ProtocolVersion.supported/isModernDiscoverResultSpec+DiscoverResult/UnsupportedProtocolVersionErrorschema conformanceT8 — #246: serve 2026-07-28 requests next to legacy requests
McpHandler:server/discover, per-request modern-version validation (-32022), dual-era dispatchresultType: completeandserverInfoin_meta; cacheable results (tools/list,resources/*,prompts/list, ...) also carryttlMs/cacheScopeMcpHandlerSpec: discover,-32022, modern and legacy-path coveragedocs/server/capabilities.mdServer conformance for 2026-07-28
serverConformance/conformance server --requirements 2026-07-28, with a per-spec-version baseline (conformance-baseline-<version>.yml) selected by the sbt taskconformance-baseline-2026-07-28.ymllists the scenarios that still need later tickets: tasks/MRTR + input-required (T5, #243), full stateless lifecycle, and modern HTTP-header validation🤖 Generated with Claude Code