fix(rewards-program): validate token account owner in revoke instructions#33
Merged
Merged
Conversation
…ions Verify that the recipient/claimant token account's internal owner field matches the actual recipient/claimant pubkey. Previously only token-program ownership was checked, allowing the authority to substitute their own token account and steal vested tokens in NonVested revoke mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_token_account_ownerutility that reads the token account's internal owner field (bytes 32..64) and compares against the expected owner pubkeyRevokeDirectRecipientRevokeMerkleClaimPreviously both revoke instructions only checked that the token account was owned by the token program (
verify_owned_by). This allowed the authority to substitute their own token account inNonVestedmode, causing vested tokens to be transferred to the authority instead of the recipient.Audit finding: #2 (Critical)
Test plan
just buildcargo test -p rewards-program --libcargo test -p tests-rewards-program test_revoke_directcargo test -p tests-rewards-program test_revoke_merkle