feat: add isEnabled toggle #92
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @andrew-bekhiet-solid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new isEnabled toggle for the LanguageToolController, allowing users to disable or enable spell checking functionality without altering the controller's underlying state. This provides more granular control over when spell checking is active, improving flexibility for the application.
Highlights
- New isEnabled Property: A boolean property isEnabled has been added to LanguageToolController to control the active state of spell checking.
- Dynamic Spell Check Control: The spell checking logic within LanguageToolController (e.g., set value, buildTextSpan, replaceMistake) now respects the isEnabled flag, preventing operations when disabled.
- Force Update Mechanism: The internal _handleTextChange method now supports a force parameter, used to re-evaluate text for mistakes immediately when spell checking is re-enabled.
- Example UI Integration: A CheckboxListTile has been added to the example application, demonstrating how to toggle the isEnabled state of the LanguageToolController from the UI.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to enable or disable spell checking via an isEnabled property on the LanguageToolController. The implementation is mostly correct, with changes to the controller to handle the enabled/disabled state in various methods like buildTextSpan, replaceMistake, and the value setter. I've found a potential memory leak when disabling the spell checker and a minor point about error handling. My review includes suggestions to address these points.
| /// Clear mistakes list when text mas modified and get a new list of mistakes | ||
| /// via API | ||
| Future<void> _handleTextChange(String newText) async { | ||
| Future<void> _handleTextChange(String newText, {bool force = false}) async { |
There was a problem hiding this comment.
Why do we need this force property?
There was a problem hiding this comment.
Because this method checks newText against current controller text and if it didn't change it doesn't highlight mistakes
So when the controller is re enabled after being disabled, the mistakes won't appear until next text change. This parameter is only used when the controller is re enabled so that it refreshes mistakes based on current text
There was a problem hiding this comment.
let's change name to smth like spellcheckSameText also I would avoid early return here as well for improved readability.
| /// Clear mistakes list when text mas modified and get a new list of mistakes | ||
| /// via API | ||
| Future<void> _handleTextChange(String newText) async { | ||
| Future<void> _handleTextChange(String newText, {bool force = false}) async { |
There was a problem hiding this comment.
let's change name to smth like spellcheckSameText also I would avoid early return here as well for improved readability.
style: avoid early returns for better readability
|
Could you please add Changelog? |
chore: bump version
illia-romanenko
left a comment
illia-romanenko
left a comment
There was a problem hiding this comment.
LGTM with small changes.
|
I think you can merge it now |
2 participants
Allows disabling spell check without changing the actual controller state