feat: allow overriding languageCheckService #93
Conversation
style: no leading underscores for local identifiers
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @andrew-bekhiet-solid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new feature that allows developers to override the default language checking service within the LanguageToolController. This enhances the flexibility and testability of the LanguageToolController by enabling custom implementations of LanguageCheckService to be injected, rather than relying solely on the built-in LangToolService.
Highlights
- Custom Service Injection: A new named constructor, LanguageToolController.withService, has been added, enabling users to provide their own LanguageCheckService implementation.
- Refactored Service Creation: The logic for creating the LanguageCheckService has been centralized into a new static method, _getLanguageCheckService, which now accepts delay parameters.
- Dependency Cleanup: The delayType and delay properties have been removed as direct fields from LanguageToolController, streamlining its core properties.
- Minor Code Improvements: Renamed a private _onTap variable to onTap for consistency and reordered parameters in the buildTextSpan method.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature by allowing a custom LanguageCheckService to be provided to the LanguageToolController. The implementation is clean, with the addition of a new withService named constructor and a refactoring of the service creation logic into a static method. The other changes are good style improvements.
I've found one potential issue related to the language property when the new withService constructor is used, which could lead to confusing behavior for developers. I've left a detailed comment with a suggestion on how to address it to make the API more robust.
Overall, great work on this feature!
andrew-bekhiet-solid
force-pushed
the
allow-providing-custom-lang-tool-service
branch
from
720b17e to
3031fe1
Compare
illia-romanenko
left a comment
illia-romanenko
left a comment
There was a problem hiding this comment.
Looks nice, thanks. Added couple comments there.
refactor!: rename baseService to _languageCheckService move debounce and throttling decorators to wrappers folder rename LangToolService to LanguageToolService
illia-romanenko
left a comment
illia-romanenko
left a comment
There was a problem hiding this comment.
Nice, added 2 similar suggestions and we should be able to finish it then. Thanks!
2 participants
No description provided.