fix: end route module ids in the source extension so unplugin filters match#2242
Open
birkskyum wants to merge 2 commits into
Open
fix: end route module ids in the source extension so unplugin filters match#2242birkskyum wants to merge 2 commits into
birkskyum wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ccfd266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route files are requested with a
?pick=...query, leaving ids likesrc/routes/index.tsx?pick=default&pick=$css. That does not end in.tsx, so plugins filtering with an end-anchored extension regex (/\.[jt]sx?$/, the default inunplugin-auto-importand friends) silently skip every route file.The query now ends with
&lang.<ext>, the same convention@vitejs/plugin-vueuses for?vue&type=script&lang.ts. The three places that built this string share atoRouteModuleId()helper.That change moves the query into Rollup's chunk base name, so
sanitizeRouteChunkNamestrips it back off viaoutput.sanitizeFileName. Output filenames are unchanged from before this PR.Verified with stock
AutoImport({ dirs: [...] })and noincludeoverride: the import is now injected into route chunks, in both build and dev. Existing suites pass (64 unit, 30 e2e, 30 bundled-dev), all fixtures build.