Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECDSAMetaTransactionContext #290

Draft
wants to merge 53 commits into
base: msg-sender-trick
Choose a base branch
from
Draft

Add ECDSAMetaTransactionContext #290

wants to merge 53 commits into from

Conversation

ItsNickBarry
Copy link
Member

@ItsNickBarry ItsNickBarry commented Mar 20, 2025 •
edited
Loading

This seems much better than using an ERC2771 trusted forwarder.

Still needs nonce invalidation.

Requires crypto-improvements branch (#289).

@ItsNickBarry
add scaffold-contract task
97cf3c7
@ItsNickBarry
fix scaffold interfaces
619f183
@ItsNickBarry
add EIP712Constants generator task
d438270
@ItsNickBarry
generate domain separator calculation functions
f6ff206
@ItsNickBarry
use assembly for chainid and address lookup
11b3cbb
@ItsNickBarry
remove assembly-sourced values from calculator parameters
136f3bc
@ItsNickBarry
restrict calculator functions to pure where possible
4ea8f31
@ItsNickBarry
generate calculator comments
72e3739
@ItsNickBarry
generate EIP712Constants tests
695cd94
@ItsNickBarry
use ejs for templating
2a0091d
@ItsNickBarry
remove template whitespace
0b0d185
@ItsNickBarry
fix test name spelling
02edad1
@ItsNickBarry
mark ECDSA assembly as memory-safe
ab23b1e
@ItsNickBarry
test FungibleTokenPermit nonces
e5bff61
@ItsNickBarry
add ECDSA#tryRecover functions using error function passing
cc7dfa2
@ItsNickBarry
fix ECDSA comments
c4f00c0
@ItsNickBarry
encapsulate error function passing within internally accessible funct…
a1f871a 
…ions
@ItsNickBarry
test tryRecover functions
d3dad19
@ItsNickBarry
fix whitespace and add comments to error wrapper functions
c71230a
@ItsNickBarry
clean up generated EIP712 whitespace
9d104ac
@ItsNickBarry
overwrite EIP712 library with procedurally generated version
3853ed6
@ItsNickBarry
reference domain hash constants in domain separator calculation funct…
ea376f3 
…ions
@ItsNickBarry
Merge branch 'crypto-improvements' into ecdsa-context
a6d7b71
@ItsNickBarry
remove view restriction from context functions
c9c3e70
@ItsNickBarry
Merge branch 'msg-sender-trick' into ecdsa-context
66061bd
@ItsNickBarry
Merge branch 'msg-sender-trick' into ecdsa-context
be3f803
@ItsNickBarry
Merge branch 'msg-sender-trick' into ecdsa-context
670d4fc
@ItsNickBarry
remove view restrictions from functions that call context functions
d36ebea
@ItsNickBarry
set evmVerion to cancun
26137ac
@ItsNickBarry
add draft ECDSAMetaTransactionContext contracts
a7510d4
@ItsNickBarry
Merge branch 'msg-sender-trick' into ecdsa-context
00776de
@ItsNickBarry
use non-reverting recover for ECDSA context
b185260
@ItsNickBarry
fix _eip712Domain output
4d633a0
@ItsNickBarry
generate ERC5267 fields constants
b3ad2be
@ItsNickBarry
test ERC5267 fields constants
a9bb1b8
@ItsNickBarry
referene ERC5267 fields constant in FungibleTokenPermit
06dc3d8
@ItsNickBarry
Merge branch 'crypto-improvements' into ecdsa-context
214fff9
@ItsNickBarry
reference ERC5267 fields constant in ECDSAMetaTransactionContext
5bef448
@ItsNickBarry
fix hash struct procedure
32e632d
@ItsNickBarry
test ECDSAMetaTransactionContext
86662f6
@ItsNickBarry
fix test nesting
be59343
@ItsNickBarry
use semi-standardized transient storage slot
054d056
@ItsNickBarry
support msg.value in ECDSAMetaTransactionContext
6087a18
@ItsNickBarry
add failing nonce revert tests
e71e5e9
@ItsNickBarry
test incorrect msg.value
d1169a5
@ItsNickBarry
fix comment
c88d411
@ItsNickBarry
replae nonce in suffix with expected signer address
5bba739
@ItsNickBarry
update comments
8db59a2
@ItsNickBarry
add toEIP712RecoverableHash utility function
b7fb3e9
@ItsNickBarry
rename function to toEthSignRecoverableHash and use assembly for hashing
c6954a3
@ItsNickBarry
test toEIP712RecoverableHash
a61388f
@ItsNickBarry
Merge branch 'crypto-improvements' into ecdsa-context
16328d2
@ItsNickBarry
use toEIP712RecoverableHash utiltity function in ECDSAMetaTransaction…
3650961 
…Context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ItsNickBarry