Add Solidus 4 support by kjriga · Pull Request #39 · solidusio-contrib/solidus_tracking

kjriga · 2025-09-02T18:38:17Z

This adds Solidus 4 support while maintaining backwards compatibility.

Updating the solidus core dependency
Fixing email subscriber for Solidus 4s refactored mailer system (ensuring compatibility with non-solidus-4)

Specs are passing locally.

All examples were filtered out; ignoring {focus: true}

Randomized with seed 26676
Finished in 1.61 seconds (files took 2.3 seconds to load)
99 examples, 0 failures

Randomized with seed 26676

Coverage report generated for RSpec to /Users/kendrariga/Documents/work-projects/solidus_tracking/coverage.
Line Coverage: 87.58% (402 / 459)

kjriga · 2025-09-05T18:15:38Z

Aware I still have a failure here spec/models/spree/order_spec.rb:81 but any initial feedback would be nice. Thanks

AlistairNorman · 2025-10-10T18:11:31Z

  spec.require_paths = ["lib"]

-  spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4']
+  spec.add_dependency 'solidus_core', ['>= 4.0.0', '< 4.6']


Can you add something in this commit about why we don't support 4.6/main?

AlistairNorman · 2025-10-10T18:13:39Z

 # Provides basic authentication functionality for testing parts of your engine
 gem 'solidus_auth_devise'

+gem 'state_machines', '0.6.0'


Can you reference the issue so we have some more context on what this is fixing?

FYI this is the issue I mean solidusio/solidus#6326

AlistairNorman · 2025-10-10T18:14:34Z

A little more context needed in a couple places but this looks good as long as tests are passing locally.

kjriga · 2025-10-15T14:26:51Z

I am happy to pull out the final commit for moving Ci -> github actions and PR it separately if it is preferred. @jarednorman I think I'll need you to update the repo to work with github actions. I took the test workflow from here but I won't know if it's working until the repo attempts to run it.

jarednorman · 2025-10-15T15:57:59Z

@kjriga If you pull the GitHub Action commit out into its own PR, I'll merge that and it'll get the CI to start running. You'll have to fix any issues with it in a separate PR.

kjriga · 2025-10-15T16:14:39Z

@kjriga If you pull the GitHub Action commit out into its own PR, I'll merge that and it'll get the CI to start running. You'll have to fix any issues with it in a separate PR.

PR

jarednorman · 2025-10-20T17:40:19Z

I've just disabled the CircleCI builds, but it looks like the GitHub builds are busted.

Edit: I see you are working on that in #42.

We want to support Solidus 4 to 4.5. I stopped at 4.5 because there are changes in 4.6+ with some 'disable_builtin_emails' configuration that required more work, so I think a plan to move forward is to make the current gemspec only allow '>= 4.0.0', '< 4.6', and add some deprecation warnings about that feature becoming obsolete. Then have a new version that's '>= 4.6.0', '<5.0' that removes it all. I am doing this work specifically to bump another app that uses it to Solidus 4, and that is my priority at the moment.

- Update method name from order_finalized to send_confirmation_email - Change target class from Spree::MailerSubscriber to Spree::OrderMailerSubscriber - Remove version conditional since gem now only supports Solidus 4+

No longer required with Solidus 4+. The method it is overriding doesn't exist anymore.

- Add the requirement of open struct now that it isn't automatically included - Change expectations to account for changes with how state changes are handled in background jobs. solidusio/solidus@2a2df71 - Replace build_stubbed with just build, some objects were missing fields - Since we removed the requirement for solidus_frontend from this gem, we don't care about the reset password email sending so we can just stub it out

Similar to the confirm email, we need this to respect the 'disable_builtin_emails' value.

Now that we're only supporting Solidus v4.0-4.5 with these changes, we need to tweak our testing matrix. Also, we were missing some configuration in order for our Github action environment variables to be able to pull the correct versions of Rails and Solidus.

At some point in Rails 7.1+, the dummy app generation changed such that it no longer would fully setup the database for us. All of our other extensions seem to have avoided this issue because they all contain some migrations and run them as part of their install steps. So, even though we don't currently add any migrations from this extension, we're adding the step so that our CI can correctly setup the test database.

We're cutting off support for older versions of Solidus so we should do a major version bump. (Even if it appears we have never changed the version of this extension since inception.)

We're no longer using CircleCI for tests, so we should switch the badge to something more useful.

forkata

Great work on these changes @kjriga and @adammathys 🎉

kjriga force-pushed the solidus-4-support branch 17 times, most recently from 1057d24 to 62461dd Compare September 5, 2025 18:15

kjriga marked this pull request as ready for review September 5, 2025 18:15

kjriga marked this pull request as draft September 5, 2025 18:15

jarednorman requested changes Sep 5, 2025

View reviewed changes

Comment thread spec/models/spree/user_spec.rb Outdated

kjriga force-pushed the solidus-4-support branch from 62461dd to fb1d3c9 Compare September 5, 2025 21:50

kjriga force-pushed the solidus-4-support branch 3 times, most recently from 147be7e to ecfc13a Compare September 19, 2025 19:17

kjriga force-pushed the solidus-4-support branch 5 times, most recently from 4787dab to b833477 Compare September 23, 2025 18:40

kjriga force-pushed the solidus-4-support branch 3 times, most recently from 046fd7c to 45f59d6 Compare October 10, 2025 17:49

kjriga marked this pull request as ready for review October 10, 2025 17:49

kjriga force-pushed the solidus-4-support branch from 45f59d6 to 3213c0f Compare October 10, 2025 17:51

kjriga requested a review from forkata October 10, 2025 17:51

kjriga force-pushed the solidus-4-support branch from 3213c0f to 55f994a Compare October 10, 2025 17:54

AlistairNorman reviewed Oct 10, 2025

View reviewed changes

kjriga force-pushed the solidus-4-support branch from 55f994a to 24aa010 Compare October 15, 2025 14:25

kjriga requested a review from jarednorman October 15, 2025 14:26

kjriga force-pushed the solidus-4-support branch 2 times, most recently from 149a0dd to 0b06fbd Compare October 17, 2025 18:49

Kendra Riga added 5 commits November 3, 2025 09:43

Update mailer subscriber for Solidus 4 compatibility

9def613

- Update method name from order_finalized to send_confirmation_email - Change target class from Spree::MailerSubscriber to Spree::OrderMailerSubscriber - Remove version conditional since gem now only supports Solidus 4+

Remove unneeded decorator

1f4717e

No longer required with Solidus 4+. The method it is overriding doesn't exist anymore.

Add decorator for DisableCancelEmail

4e40479

Similar to the confirm email, we need this to respect the 'disable_builtin_emails' value.

adammathys force-pushed the solidus-4-support branch 2 times, most recently from b44a1d6 to c80f7aa Compare November 3, 2025 22:00

adammathys added 4 commits November 4, 2025 08:55

Bump to v1.0.0

26937ba

We're cutting off support for older versions of Solidus so we should do a major version bump. (Even if it appears we have never changed the version of this extension since inception.)

Update README with Github actions badge

c3e0e91

We're no longer using CircleCI for tests, so we should switch the badge to something more useful.

forkata approved these changes Nov 4, 2025

View reviewed changes

jarednorman approved these changes Nov 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Solidus 4 support#39

Add Solidus 4 support#39
adammathys merged 9 commits into
solidusio-contrib:mainfrom
kjriga:solidus-4-support

kjriga commented Sep 2, 2025 •

edited

Loading

Uh oh!

kjriga commented Sep 5, 2025

Uh oh!

Uh oh!

AlistairNorman Oct 10, 2025

Uh oh!

AlistairNorman Oct 10, 2025

Uh oh!

AlistairNorman Oct 11, 2025

Uh oh!

AlistairNorman commented Oct 10, 2025

Uh oh!

kjriga commented Oct 15, 2025 •

edited

Loading

Uh oh!

jarednorman commented Oct 15, 2025

Uh oh!

kjriga commented Oct 15, 2025

Uh oh!

jarednorman commented Oct 20, 2025 •

edited

Loading

Uh oh!

forkata left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kjriga commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjriga commented Sep 5, 2025

Uh oh!

Uh oh!

AlistairNorman Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

AlistairNorman Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

AlistairNorman Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

AlistairNorman commented Oct 10, 2025

Uh oh!

kjriga commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarednorman commented Oct 15, 2025

Uh oh!

kjriga commented Oct 15, 2025

Uh oh!

jarednorman commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

forkata left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kjriga commented Sep 2, 2025 •

edited

Loading

kjriga commented Oct 15, 2025 •

edited

Loading

jarednorman commented Oct 20, 2025 •

edited

Loading