Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compliance] Store reverse charge status #6136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Feb 19, 2025

Concerns (but doesn't solve): #6112 #6110

Summary

This is the first in a series of PRs to achieve fiscal compliance with EU regulation on Solidus easier.
This dropdown, which will also be introduced on Addresses in the future allows to set a Store as reverse charge compliant, allowing to decide on a per store front level if reverse charge can be applied.

This can be especially useful if driving different stores with different legal entities.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Store model now has an enum for reverse_charge_status which let's user choose
whether it is enabled, disabled or not validated.
Allows access to the reverse_charge_status attribute through existing store APIs.
Updated the store form for reverese_charge_status
user can select the charge status from the dropdown for the store
@fthobe fthobe requested a review from a team as a code owner February 19, 2025 10:16
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Feb 19, 2025
@fthobe
Copy link
Contributor Author

fthobe commented Feb 19, 2025

@shahmayur001 We need to add the OpenAPI docs for this one.

@fthobe
Copy link
Contributor Author

fthobe commented Feb 19, 2025

@kennyadsl should be ok, only test failing is store credit being flaky on admin

@fthobe
Copy link
Contributor Author

fthobe commented Feb 22, 2025

@tvdeyen @kennyadsl Failing test doesn't seem to be related, can we merge this? It's a preparatory step for fixing the vat discussion and allows to either manually or via API determine reverse charge status when we also integrate the organisation fields from PR #6113 down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants