Add REST API #23
Add REST API #23
Conversation
|
Thanks for the contribution! Unfortunately we can't verify if the committer(s), Alexey Vishniakov [email protected], signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Sonatype Contributor License Agreement and this Pull Request will be revalidated. |
|
Thanks for the contribution! Before we can merge this, we need @android-leha to sign the Sonatype Contributor License Agreement. |
There was a problem hiding this comment.
Thank you for your contribution! Nice job!
Also, it is good practice to have Integration tests. Please see the example for R format integration tests for REST API. https://github.com/sonatype-nexus-community/nexus-repository-r/pull/127/files
If you have any questions or troubles with Integration tests don't hesitate to ask.
...itory-apk/src/main/java/org/sonatype/nexus/plugins/apk/api/ApkProxyRepositoryApiRequest.java
Outdated
Show resolved
Hide resolved
...y-apk/src/main/java/org/sonatype/nexus/plugins/apk/rest/ApkProxyRepositoriesApiResource.java
Outdated
Show resolved
Hide resolved
...itory-apk/src/main/java/org/sonatype/nexus/plugins/apk/api/ApkProxyRepositoryApiRequest.java
Outdated
Show resolved
Hide resolved
...itory-apk/src/main/java/org/sonatype/nexus/plugins/apk/api/ApkProxyRepositoryApiRequest.java
Outdated
Show resolved
Hide resolved
|
Hi @aornatovskyy, I did all reqiried changes, but build has issues with tests. What's wrong? |
@android-leha Thanks for your contribution and fast IT implementation. Sure will try to help you, give me some time for that. |
|
|
@android-leha not sure what issue you faced. I see that now API is incompatible because we had couple of changes in the API. I will help you to make it compatible with the latest 3.26.0 which is going to be released soon. |
|
I found one more API changes. Will apply it soon in the main repo then you will be able to pull it into your project and finish work with REST. |
|
@android-leha can you please include the latest changes from master and try run your tests again? Hope now it should work and we will merge it to the master. |
|
please merge if possible |
|
@vsuzdaltsev Were you able to build this branch and verify it works for you? If so, I'll try to get some cycles to get it merged. |
Exposing REST API for APK proxy repositories
Requested from #22
cc @DarthHater @bhamail