This repository was archived by the owner on Aug 31, 2022. It is now read-only.
telemetry client updated to stream structured events#111
Open
renukamanavalan wants to merge 11 commits intosonic-net:masterfrom
Open
telemetry client updated to stream structured events#111renukamanavalan wants to merge 11 commits intosonic-net:masterfrom
renukamanavalan wants to merge 11 commits intosonic-net:masterfrom
Conversation
gnmi_cli -client_types=gnmi -a 127.0.0.1:50051 -t EVENTS -logtostderr -insecure -v 7 -streaming_type ON_CHANGE -q aaa/bbb -qt s
Adding client to receive & send to subscribing clients
renukamanavalan
requested review from
abdosi,
qiluo-msft,
yozhao101 and
zbud-msft
|
This pull request introduces 1 alert when merging 8e243a2 into 1ac0e0e - view on LGTM.com new alerts:
|
6 tasks
Author
|
@yozhao101, @abdosi, @zbud-msft, @qiluo-msft, Can you please provide your reviews, ASAP ? |
yozhao101
reviewed
Jul 18, 2022
Contributor
|
can we please add some UT here ? |
zbud-msft
approved these changes
Jul 25, 2022
Author
Yes we do. @abdosi , can you please comment/approve? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Refer: sonic-net/SONiC#954
NOTE: Dependent on PR #649 and update of swss-common in buildimage.
How I did it
Added a new client with APIs from libswsscommon to receive events.
How to verify it
After buildimage PR too checked in for this feature, toggle BGP states and note events streaming out.
gnmi_cli -client_types=gnmi -a 127.0.0.1:50051 -t EVENTS -logtostderr -insecure -v 7 -streaming_type ON_CHANGE -q aaa/bbb -qt s
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)