Skip to content
This repository was archived by the owner on Aug 31, 2022. It is now read-only.

Support gnmi set, add some testcases and fix some bugs#14

Open
liuqu wants to merge 34 commits intosonic-net:masterfrom
liuqu:master
Open

Support gnmi set, add some testcases and fix some bugs#14
liuqu wants to merge 34 commits intosonic-net:masterfrom
liuqu:master

Conversation

@liuqu
Copy link

@liuqu liuqu commented Aug 23, 2018 •
edited
Loading

The detail change list:

  1. Add option tlsDisable for testing
  2. Add glide to support golang package dependencies management
  3. Support gnmi set
  4. Support non_db path: version, ntp, bgp neighbor, rib num, interface rate
  5. Refactor the db_table path module
  6. Support the field with wildcard in virtual path, add testcase for vpath module

Liuqu and others added 30 commits August 22, 2018 08:24
Fix testdata file name invalid in windows OS
d75ef11
Fix dialout_client subscription paths update error
b151df5
Support wildcard field for virtual db path
ed69aeb
Support Set RPC in gNMI to modify data in configDB
2656f4e
Fix single port counter always get all fields value
e65399e
Add unittest for virtual_db
e034478
Fix stream get multiple fields error
27ccce5
Add test case for gNMI Set
3f079bd
Add device name for dialout publish message
b298ca0
Add option to disable TLS
df8e3dd
Add support for RPC Set json value
b99bc6b
Separate path module from db_client and add testcase
dcb76f8 
- Move the code that get DB table/key/field from gNMI path to path.go
- Add testcase for path module
- Add permit path list for SET RPC, and add testcase to cover it
Add glide dependency file to finish go dependency management
c079dbd
Add db target check when get db table path
ae5503b
Separate system module from non_db_client
d2c5ab7
Add support for system version
45be005
Add support for system ntp and shutdown state
fad9214
Change system memory and down message format
44b24a5
@shupengzhang
[telemetry]add grpc requirement
84241e3
@shupengzhang
[telemetry]add grpc show interface rxtx rate
07e6ad3
@shupengzhang
[telemetry]add grpc set configdb
3dc8f0b
Temporarily remove return error when table path check fail
246a62d 
- Need to refactor path module to support non-path -> valide path
  in stream or periodic mode
@shupengzhang
[telemetry]change bpg summary key name
a59e0c3
@shupengzhang
[telemetry]fix stream data without key
2cc321e
@shupengzhang
[telemetry]fix peridic mode send package time and set configdb with json
6c8016e 
file bug
Add allowNotFound for stream mode and fix test fail
de19489
@shupengzhang
[telemetry]fix stream data without key
49420b2
@shupengzhang
[telemetry]add grpc test case
d319d87
@shupengzhang
[telemetry]fix dialout mode when server disconnect client closed
955fc1b
@shupengzhang
[telemetry]add replace db with json file
c9d5445
@jipanyang
Copy link
Collaborator

jipanyang commented Aug 23, 2018

I'm afraid you need to break them into smaller feature pieces, and provide necessary description and document update for each of them.

lguohan
lguohan suggested changes Aug 27, 2018
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

@lguohan lguohan requested a review from jleveque August 27, 2018 21:57
@lguohan
Copy link
Contributor

lguohan commented Aug 30, 2018

agree with jipan, can you break this PR into different PRs?

@TildenWinston TildenWinston mentioned this pull request Aug 3, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jleveque jleveque Awaiting requested review from jleveque

1 more reviewer

@lguohan lguohan lguohan requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuqu @jipanyang @lguohan @stcheng @shupengzhang