This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Fix Ctrl+C to terminate dialout_client_cli#25
Open
MuLinForest wants to merge 1 commit intosonic-net:masterfrom
Open
Fix Ctrl+C to terminate dialout_client_cli#25MuLinForest wants to merge 1 commit intosonic-net:masterfrom
MuLinForest wants to merge 1 commit intosonic-net:masterfrom
Conversation
|
retest this please. |
1 similar comment
|
retest this please. |
Contributor
|
Retest this please |
|
retest this please |
Contributor
|
I noticed this issue as well but I thought this would fix it instead: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl+C cannot terminate dialout_client_cli until dialout_client received the Redis Pub/Sub message.
The reason is that the code to check the ctx.Done() is behind the code to receive message.
Therefore, I move the checking code in order to terminate the program even if there is no Redis Pub/Sub message received.