This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Open
Conversation
Align SFP key names in test DB data with new standard defined in sonic-net/sonic-platform-common#97 - hardwarerev -> hardware_rev - serialnum -> serial - manufacturename -> manufacturer - modelname -> model - Connector -> connector
This was the result of running go get github.com/openconfig/gnmi This was required to fix build issue seen in sonic-net/sonic-buildimage#4986 After adding these changes I did a make clean && rm -rf vendor in both sonic-telemetry and sonic-mgmt-common repo and was able to build.
hui-ma
reviewed
Aug 10, 2020
Spelling fix
Spelling fix
Formatting fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating build steps and added table of common errors. This replaces the out of date instructions to use go get which no longer functions.
Steps were compiled with the help of @sachinholla .