Skip to content

Migrate out of react-responsive to @mantine/hooks #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented May 2, 2024

Description

Closes #2967.

TODO:

  • Migrate/remove MediaQuery HOC
  • Remove react-responsive from package.json

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces May 2, 2024 09:19
@RichDom2185 RichDom2185 self-assigned this May 2, 2024
@coveralls
Copy link

coveralls commented May 2, 2024

Pull Request Test Coverage Report for Build 9050551254

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 32.001%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/mobileWorkspace/MobileWorkspace.tsx 0 1 0.0%
Totals Coverage Status
Change from base Build 9050524219: 0.04%
Covered Lines: 5037
Relevant Lines: 14787

💛 - Coveralls

@RichDom2185 RichDom2185 marked this pull request as ready for review May 12, 2024 10:03
Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @sayomaki, LGTM! Could you help approve, since I can't approve my own PR?

Thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) May 12, 2024 10:04
@RichDom2185 RichDom2185 merged commit f8f495e into master May 12, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the responsive-migration branch May 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate out of react-responsive
4 participants