Skip to content

Migrate to Redux Toolkit part 10 #2995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 12, 2024
Merged

Migrate to Redux Toolkit part 10 #2995

merged 22 commits into from
May 12, 2024

Conversation

RichDom2185
Copy link
Member

Description

Focused mainly on migrating from createAction to our helper functions, as well as removing default imports. There should be no breaking change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from chownces May 12, 2024 11:42
@RichDom2185 RichDom2185 self-assigned this May 12, 2024
@RichDom2185 RichDom2185 requested a review from sayomaki May 12, 2024 11:46
@coveralls
Copy link

coveralls commented May 12, 2024

Pull Request Test Coverage Report for Build 9052724513

Details

  • 101 of 360 (28.06%) changed or added relevant lines in 21 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 31.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/missionCreator/MissionCreator.tsx 0 1 0.0%
src/commons/sagas/SideContentSaga.ts 9 10 90.0%
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts 2 3 66.67%
src/commons/sideContent/SideContentActions.ts 7 9 77.78%
src/features/sourceRecorder/sourcereel/SourcereelActions.ts 9 11 81.82%
src/commons/application/actions/SessionActions.ts 5 8 62.5%
src/commons/sagas/BackendSaga.ts 34 40 85.0%
src/features/remoteExecution/RemoteExecutionActions.ts 3 9 33.33%
src/features/groundControl/GroundControlActions.ts 2 11 18.18%
src/commons/assessmentWorkspace/AssessmentWorkspace.tsx 8 21 38.1%
Files with Coverage Reduction New Missed Lines %
src/commons/sagas/RemoteExecutionSaga.ts 3 6.99%
src/commons/sagas/AchievementSaga.ts 7 0.68%
Totals Coverage Status
Change from base Build 9050698198: -0.4%
Covered Lines: 4921
Relevant Lines: 14690

💛 - Coveralls

Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the changes again and looks good, thanks for helping with the review @chownces!

@RichDom2185 RichDom2185 merged commit d69b834 into master May 12, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the rtk-10 branch May 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants