-
Notifications
You must be signed in to change notification settings - Fork 172
Rewrite:stepper Fix frontend to be compatible with js-slang rewrite/stepper #3125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite:stepper Fix frontend to be compatible with js-slang rewrite/stepper #3125
Conversation
(Not finished) |
Pull Request Test Coverage Report for Build 15603271398Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I think everything is finalized (except <<, >> feature which we plan to include them later). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a few examples; works well. Implementation is clear. Good to go I think.
Description
This PR aims to rewrite the code visualizer for the new stepper (source-academy/js-slang#1742) with new interactive features such as hovering on mu term for function definition. Instead of using React-ace library, this PR implements the code renderer from scratch while maintaining important features such as syntax highlighting and parentheses handling.
Type of change
Remarks
src/commons/sideContent/content/_SideContentSubstVisualizer.tsx
is the previous version. The new version is implemented insrc/commons/sideContent/content/SideContentSubstVisualizer.tsx
.Checklist