Skip to content

Add language options, any checker and tests #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

tohlh
Copy link
Contributor

@tohlh tohlh commented Apr 5, 2025

This PR adds the any checker with language options to allow instructors to configure the strictness of Source Typed variants. Relevant tests are also added to ensure the checker works as intended.

Please refer to these PRs:

  1. Language options backend#1247
  2. Language options frontend#3123

@coveralls
Copy link

coveralls commented Apr 5, 2025

Pull Request Test Coverage Report for Build 14523301467

Details

  • 15 of 88 (17.05%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 80.538%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/repl/utils.ts 3 7 42.86%
src/parser/source/typed/index.ts 6 75 8.0%
Totals Coverage Status
Change from base Build 14473828767: -0.6%
Covered Lines: 10811
Relevant Lines: 13030

💛 - Coveralls

@RichDom2185 RichDom2185 self-requested a review April 5, 2025 22:34
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the rationale of using a Map<string, string> instead of Record<string, string>?

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit fea2b4c into source-academy:master Apr 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants