Resolve the instance's own schemas without the caller's credential - #1182
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR fixes a crash/regression where MCP requests could bring the server down when the caller’s credential was allowed to access Changes:
Technical Notes: Structural validation resolves precompiled Blaze artifacts via the unauthenticated resolver (still canonicalized/contained), while any caller-requested schema evaluation remains credential-gated. 🤖 Was this summary useful? React with 👍 or 👎 |
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 5523486 | Previous: fe6ab0d | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
275 ms |
333 ms |
0.83 |
Add one schema (100 existing) |
28 ms |
28 ms |
1 |
Add one schema (1000 existing) |
100 ms |
86 ms |
1.16 |
Add one schema (10000 existing) |
873 ms |
741 ms |
1.18 |
Update one schema (1 existing) |
21 ms |
21 ms |
1 |
Update one schema (101 existing) |
28 ms |
28 ms |
1 |
Update one schema (1001 existing) |
97 ms |
84 ms |
1.15 |
Update one schema (10001 existing) |
880 ms |
735 ms |
1.20 |
Cached rebuild (1 existing) |
6 ms |
7 ms |
0.86 |
Cached rebuild (101 existing) |
8 ms |
9 ms |
0.89 |
Cached rebuild (1001 existing) |
27 ms |
29 ms |
0.93 |
Cached rebuild (10001 existing) |
236 ms |
254 ms |
0.93 |
Index 100 schemas |
639 ms |
612 ms |
1.04 |
Index 1000 schemas |
1546 ms |
1432 ms |
1.08 |
Index 10000 schemas |
13057 ms |
13893 ms |
0.94 |
Index 10000 schemas (custom meta-schema) |
15556 ms |
16772 ms |
0.93 |
Index 10000 schemas ($ref fan-out) |
15524 ms |
16702 ms |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 5523486 | Previous: fe6ab0d | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
392 ms |
542 ms |
0.72 |
Add one schema (100 existing) |
108 ms |
108 ms |
1 |
Add one schema (1000 existing) |
157 ms |
151 ms |
1.04 |
Add one schema (10000 existing) |
865 ms |
938 ms |
0.92 |
Update one schema (1 existing) |
97 ms |
85 ms |
1.14 |
Update one schema (101 existing) |
103 ms |
92 ms |
1.12 |
Update one schema (1001 existing) |
159 ms |
162 ms |
0.98 |
Update one schema (10001 existing) |
777 ms |
1067 ms |
0.73 |
Cached rebuild (1 existing) |
8 ms |
7 ms |
1.14 |
Cached rebuild (101 existing) |
11 ms |
10 ms |
1.10 |
Cached rebuild (1001 existing) |
31 ms |
29 ms |
1.07 |
Cached rebuild (10001 existing) |
258 ms |
234 ms |
1.10 |
Index 100 schemas |
668 ms |
646 ms |
1.03 |
Index 1000 schemas |
1591 ms |
1502 ms |
1.06 |
Index 10000 schemas |
13795 ms |
14232 ms |
0.97 |
Index 10000 schemas (custom meta-schema) |
17271 ms |
18496 ms |
0.93 |
Index 10000 schemas ($ref fan-out) |
17035 ms |
17633 ms |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com