Fix broken toolbar backdrop after scrolling down on mobile #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to review this, but there are a lot of unrelated changes. Can you rebase on feature/a11ymap @opyh ? |
opyh
force-pushed
the
fix/toolbar-backdrop
branch
from
038e655 to
f1d3cca
Compare
Mayaryin
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you scroll down the feature details toolbar on a phone, the blurred backdrop is missing. This PR fixes the issue.
Before:
https://github.com/user-attachments/assets/13e78c19-8a02-4191-876b-d5c8a7e6c62c
After:
https://github.com/user-attachments/assets/4762b9f7-3112-4ce3-87b8-c0fdf173835e
Feel free to test on https://fix-toolbar-backdrop.wheelmap.tech/composite/amenities:node:1773535496,buildings:way:24862622. Please test in dark mode, colors are changed/fixed in another branch.
📎 Related Ticket
🔗 Dependencies: Needs merging #490 first.
💪 I have tested my code
- [ ] The feature deployment works. - [ ] The automated tests are passing. - [x] I have manually tested this feature - [x] on mobile - [x] in Chrome✨ I have created a nice pull request
- [x] It has a clear title. - [x] It follows the template, has a clear description and testing instructions if needed. - [x] It references applicable Asana tickets. - [x] It targets the right branch. - [x] I removed not applicable sections of the PR template. - [ ] [optional] I added a GIF of my favorite animal to the PR description to lighten the mood of my colleagues.