Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/a11ymap clean up edit error handling #503

Draft
wants to merge 9 commits into
base: feature/a11ymap
Choose a base branch
from

Conversation

Mayaryin
Copy link
Contributor

@Mayaryin Mayaryin commented Feb 24, 2025

GIF

🖊️ Description

💡 What? Why? How?

Error handling in AutoEditor.tsx was very detailed and targets multiple different error scenarios (db failure, api failure).
In case of a db problem, the edit will still be saved to osm and later be re-imported to our db. Thus, the user should see a success message stating that the edit will become visible in a while.

➕ Additonal comments/questions

I added some explanatory comments that will be removed.

📎 Related Ticket

👀 Sneak Peek (Optional)

Include the link to the feature deployment or screenshots/a video.

⚠️ Creation checklist

Before creating this merge request, go over the following checklist (click to expand).
Remove any items that are not applicable.

💪 I have tested my code
  • A new E2e playwright test covers this feature / A new test that reproduces the bug passes now.
  • The feature deployment works.
  • The automated tests are passing.
  • I have manually tested this feature
    • on mobile
    • by using keyboard-only navigation
    • with a screen reader (VoiceOver is fine)
    • in Chrome
    • in Firefox
    • in Safari
🧼 I have cleaned up my code
  • I have removed dependencies that were just for testing.
  • I have removed debug logging.
  • My code does not generate new warnings.
  • My code does not depend on new vulnerable packages.
  • The commit messages are precise and make sense (rebase the PR with --interactive if applicable, keeping commits in sensible chunks if possible).
🔍 I have performed a self-review of my code
  • My code is self-documenting or has links to necessary documentation.
  • New function and variables names can be understood by new developers with basic project knowledge.
  • The feature fits the design.
✨ I have created a nice pull request
  • It has a clear title.
  • It follows the template, has a clear description and testing instructions if needed.
  • It references applicable Asana tickets.
  • It targets the right branch.
  • I removed not applicable sections of the PR template.
  • [optional] I added a GIF of my favorite animal to the PR description to lighten the mood of my colleagues.
📝 I updated the documentation
  • I updated the documentation in this repository.
  • I updated the tech manual.
  • I updated the manual testing plan of the app so that it includes a testing flow for this feature.

🔍 Reviewing

When reviewing this merge request, here are some things to keep in mind:

@Mayaryin Mayaryin changed the base branch from main to feature/a11ymap February 24, 2025 16:01
@Mayaryin Mayaryin force-pushed the chore/a11ymap-clean-up-edit-error-handling branch from 44565f5 to c75b897 Compare February 24, 2025 16:19
@kriskbx kriskbx self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants