Chore/add test for editor #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a picker to StringFieldEditor.tsx - made StringFieldEditor.tsx and AutoEditor.tsx aware of the selected picker value - added util function to strip off any language tag if present - added new language tag to osm tag if the language is -changed ToDos: - move icons to another location/inside the picker file - get and organize a list of ietf language tags to display in the drop down - make button unclickable if no language is selected? - handle the case that someone wants to add a new localized description when a general description already exists --> what should happen to the text in the text area if the language is changed?
Mayaryin
force-pushed
the
chore/add-test-for-editor
branch
from
62e41d1 to
6988dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖊️ Description
Added tests for the editor components WheelchairEditor, ToiletsWheelchairEditor and StringFieldEditor.
The StringFieldEditor is used in two cases: for adding a new description and for editing the currently displayed description.
The feature details are mocked for testing.
Two test cases are still missing: keyboard navigation and wcag compliance. These will be addressed in another issue, since especially wcag compliance needs some refactoring of the components. This PR is to get some tests out for this feature.
I also moved the Editor components to a new modules directory called "edit" and also placed the tests there.
📎 Related Ticket
Before creating this merge request, go over the following checklist (click to expand).
Remove any items that are not applicable.
💪 I have tested my code
🧼 I have cleaned up my code
--interactiveif applicable, keeping commits in sensible chunks if possible).🔍 I have performed a self-review of my code
✨ I have created a nice pull request
🔍 Reviewing
When reviewing this merge request, here are some things to keep in mind: