feat: list view #510
Draft
feat: list view #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskbx
force-pushed
the
feature/a11ymap
branch
from
d45aec4 to
4589f27
Compare
# Conflicts: # src/components/App/MapLayout.tsx # src/components/CombinedFeaturePanel/editors/WheelchairEditor.tsx # Conflicts: # src/components/App/MapLayout.tsx # src/components/CombinedFeaturePanel/components/image/WikidataEntityImage.tsx # src/components/CombinedFeaturePanel/editors/WheelchairEditor.tsx # src/components/CombinedFeaturePanel/utils/useFeatureLabel.tsx # src/components/TopBar.tsx # src/components/shared/Toolbar.tsx # src/lib/fetchers/osm-api/fetchOSMFeatureCollection.ts # src/lib/fetchers/useFeatures/fetchers.ts # src/lib/model/geo/placeNameFor.ts # src/modules/categories/components/CategoryFilter.tsx # src/modules/needs/components/NeedsButton.tsx # src/modules/needs/components/NeedsDropdownSection.tsx # src/modules/needs/needs.ts # src/modules/search/components/SearchFormField.tsx # src/modules/search/tests/empty-photon-mock.json # src/modules/search/tests/empty-place-infos-mock.json # src/modules/search/tests/node:3908141014-osm-mock.json # src/modules/search/tests/photon-mock.json # src/modules/search/tests/place-infos-mock.json # src/modules/search/tests/way:23723125-osm-mock.json # src/pages/_app.tsx # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖊️ Description
💡 What? Why? How?
For example: I solved a performance issue which impacted usability by implementing a flux compensator in the queue manager.
➕ Additonal comments/questions
For example: I am specifically looking for feedback on the implementation of...
📎 Related Ticket
Add an Asana link
🔗 PR Dependencies
Include links to other PRs, that this PR depends on and that need to be merged beforehand
👀 Seak Peek (Optional)
Include the link to the feature deployment or screenshots/a video.
Before creating this merge request, go over the following checklist (click to expand).
Remove any items that are not applicable.
💪 I have tested my code
🧼 I have cleaned up my code
--interactiveif applicable, keeping commits in sensible chunks if possible).🔍 I have performed a self-review of my code
✨ I have created a nice pull request
📝 I updated the documentation
🔍 Reviewing
When reviewing this merge request, here are some things to keep in mind:
🍸 Optional: Installation instructions
Remove this section, if you don't need it
For example: Reinstall your dependencies, rebuild your docker image, add something to your
.env🔬 Optional: Testing instructions
Remove this section, if you don't need it
For example: To test this feature, click on the "Create" button, fill out the form, click "Save" and then upload a file.