Finish base webhooks #1261
Closed
Finish base webhooks #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2025 08:33
…update_webhooks
Comment on lines
+159
to
+166
| const blockedContains = ["discord", "clyde", "spacebar"]; | ||
| for (const word of blockedContains) { | ||
| if (body.username.toLowerCase().includes(word)) { | ||
| return res.status(400).json({ | ||
| username: [`Username cannot contain "${word}"`], | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
should this not be a config option? this code is repeated in src/api/routes/channels/#channel_id/webhooks.ts which I'm not a fan of
There was a problem hiding this comment.
this is how the code was before in spacebar, this isn't new, though I get wanting it to be an option
| throw DiscordApiErrors.UNKNOWN_WEBHOOK; | ||
|
|
||
| if (!body.name && !body.avatar && !body.channel_id) { | ||
| throw new HTTPError("Empty messages are not allowed", 50006); |
There was a problem hiding this comment.
slightly misleading error message?
|
hey, just to note, you might wanna do what the failed test says to do |
|
Im gonna close this as I added in some new stuff to complete and merge with another pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this update, me and Mathium worked on finishing the updates required to fully reimplement the api for webhooks in such a way that matched expected behaviors across the board